xBis7 opened a new pull request, #62705:
URL: https://github.com/apache/airflow/pull/62705
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
related discussion:
https://github.com/apache/airflow/pull/62019#discussion_r2812822658
## DualStatsManager code explanation
Usually the legacy metrics don't have any tags and all the variables are
included in the name.
The `tags` dict refers to tags that are set on both the new name metric and
the legacy name metric (separately from the name variables).
The `legacy_name_tags` dict refers to the legacy name variables.
The legacy metrics will only have the `tags` values as tags.
Both dictionaries are eventually merged and the resulting dict is used for
the final tags of the new metric.
For example,
```
tags={},
legacy_name_tags=tags
```
the legacy metric won't have any tags and after that is exported, `{}` and
`tags` are merged and then set as the new metric tags.
## Patch changes
The patch is consisted of the following changes
* renamed `extra_tags` to `legacy_name_tags` for clarity
* added explanation comments in the `DualStasManager`
* replaced the word `...extra...` with the word `...legacy...` in all
references
* cleaned up mess-ups with the `tags` and `legacy_name_tags` params
* added missing stats in the `metrics_template.yaml`
* for providers, followed the `try-except` pattern for the DualStatsManager
import and maintained the old Stats calls as fallbacks
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
- [X] No
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
