o-nikolas commented on code in PR #62649:
URL: https://github.com/apache/airflow/pull/62649#discussion_r2874254565
##########
airflow-core/src/airflow/utils/helpers.py:
##########
@@ -295,6 +296,29 @@ def is_empty(x):
return val
+def filter_kwargs(callable_obj: Callable[..., Any], kwargs: dict) -> dict:
+ """
+ Filter kwargs to only include parameters the callable accepts.
Review Comment:
This method is unexpectedly generalized. I'd scope it down to just filtering
`context`. It makes the code easier to understand and then it can live much
closer to the Deadlines code where it's only being used now.
We can always generalize it later if there is a need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
