jason810496 commented on code in PR #62701:
URL: https://github.com/apache/airflow/pull/62701#discussion_r2875778114
##########
task-sdk/src/airflow/sdk/io/path.py:
##########
@@ -99,7 +99,7 @@ def __init__(
if args:
arg0 = args[0]
if isinstance(arg0, type(self)):
- storage_options["conn_id"] =
arg0.storage_options.get("conn_id")
+ storage_options["conn_id"] = arg0.conn_id
Review Comment:
We're using `arg0.conn_id` here, and `conn_id` is now a property that return
`getattr(self, "_conn_id", None)`, and the `TestConnIdPropagation` test show
that `conn_id` will not drop between mixed old/new instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
