Prab-27 commented on code in PR #62682:
URL: https://github.com/apache/airflow/pull/62682#discussion_r2877277043
##########
dev/breeze/src/airflow_breeze/utils/github.py:
##########
@@ -355,3 +356,205 @@ def download_artifact_from_pr(pr: str, output_file: Path,
github_repository: str
get_console().print(f"[info]Found run id {run_id} for PR {pr}")
download_artifact_from_run_id(str(run_id), output_file, github_repository,
github_token)
+
+
+_CONTRIBUTING_DOCS_URL =
"https://github.com/apache/airflow/blob/main/contributing-docs";
+_STATIC_CHECKS_URL = f"{_CONTRIBUTING_DOCS_URL}/08_static_code_checks.rst"
+_TESTING_URL = f"{_CONTRIBUTING_DOCS_URL}/09_testing.rst"
+
+# Patterns to categorize failing CI check names
+_CHECK_CATEGORIES: list[tuple[str, list[str], str, str]] = [
+ # (category, name_patterns, fix_instructions, doc_url)
+ (
+ "Pre-commit / static checks",
+ ["static checks", "pre-commit", "prek"],
+ "Run `prek run --ref-from main` locally to find and fix issues.",
+ _STATIC_CHECKS_URL,
+ ),
+ (
+ "Ruff (linting / formatting)",
+ ["ruff"],
+ "Run `prek run ruff --ref-from main` and `prek run ruff-format
--ref-from main` to fix.",
+ f"{_STATIC_CHECKS_URL}#using-prek",
+ ),
+ (
+ "mypy (type checking)",
+ ["mypy"],
+ "Run `prek run mypy --ref-from main --hook-stage pre-push` locally. "
Review Comment:
1 - this command shows error since only `mypy`
Could we update this `mypy-folder`
2 - Does this fine or we need to use only one term ?
prek --help shows --stage and we generally use --hook-stage
Would you please share your point of view ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
