yuseok89 opened a new pull request, #62791:
URL: https://github.com/apache/airflow/pull/62791
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
This PR resolves a mismatch between the Google Ads connection form and the
hook's expected input format. I discovered this issue while testing another
PR(#61334). When users filled in the connection form (developer token, client
ID, client secret, refresh token), the values were stored as flat keys in
`extra`. However, the hook only read the nested `google_ads_client` structure,
causing connection failures.
## Before
**Error when entering values via the connection form:**
<img width="896" height="368" alt="image"
src="https://github.com/user-attachments/assets/bd43b1d6-ecda-4af2-8398-f70cd1995c6d";
/>
**What the hook expected (nested format):**
<img width="615" height="247" alt="image"
src="https://github.com/user-attachments/assets/b43fa0ea-4f87-44ca-8374-1db7663d8dfe";
/>
## After
**Supported connection form fields (flat format stored in extra):**
<img width="616" height="275" alt="image"
src="https://github.com/user-attachments/assets/78e5a710-1489-44a6-86bd-f158a88cc948";
/>
**How the connection was tested:**
```python
ads_hook = GoogleAdsHook(gcp_conn_id=..., google_ads_conn_id=...)
accessible = ads_hook.list_accessible_customers() # Succeeds with flat extra
```
The hook now accepts both:
- **Flat format** (from connection form): `developer_token`, `client_id`,
etc. at top level
- **Nested format** (legacy): `google_ads_client` with nested keys
**_Connection works when entering values via the connection form._**
<img width="707" height="84" alt="image"
src="https://github.com/user-attachments/assets/57a90d92-6069-4e64-b9df-d3c36c6aad27";
/>
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (please specify the tool below)
- Cursor
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
* * * *
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
