hwang-cadent commented on PR #56973: URL: https://github.com/apache/airflow/pull/56973#issuecomment-3992072949
> > > Looking good to me apart from question if this change should also not be directly tested in test_serialized_objects instead of relying on indirect tests? > > > > > > Good point. Currently tested indirectly through TriggerDagRunOperator tests. A direct unit test in test_serialized_objects.py for _deserialize_field_value() handling ARG_NOT_SET for date fields would be clearer. Should I add this test, or would you prefer to handle it in a follow-up? > > It think it would be better even though it's indirectly tested through TriggerDagRunOperator tests. So yes would add case in test_serialized_objects. Thanks for the feedback. I've added a direct test case test_deserialize_field_value_with_arg_not_set_for_date_fields in test_serialized_objects.py to verify that _deserialize_field_value returns NOTSET for ARG_NOT_SET date fields. This complements the indirect tests through TriggerDagRunOperator and improves test coverage. The test verifies the behavior for date fields like logical_date, start_date, and end_date when they contain ARG_NOT_SET values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
