nailo2c commented on code in PR #62772:
URL: https://github.com/apache/airflow/pull/62772#discussion_r2879977473
##########
providers/microsoft/azure/src/airflow/providers/microsoft/azure/operators/container_instances.py:
##########
@@ -417,6 +459,44 @@ def on_kill(self) -> None:
except Exception:
self.log.exception("Could not delete container group")
+ def execute_complete(self, context: Context, event: dict[str, Any] | None)
-> int:
+ """
+ Handle the trigger event after deferral.
+
+ Called by the Triggerer when the container reaches a terminal state.
+ Raises an AirflowException on failure; returns the exit code on
success.
+ """
+ if event is None:
+ raise AirflowException("Trigger error: event is None")
Review Comment:
Thanks for implementing this!
Nit: per the contributing guide, we avoid raising `AirflowException`
directly. Could you raise a built-in exception here instead?
https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#dont-raise-airflowexception-directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
