vincbeck commented on code in PR #62664:
URL: https://github.com/apache/airflow/pull/62664#discussion_r2880312860
##########
devel-common/src/docs/provider_conf.py:
##########
@@ -361,29 +361,17 @@
from airflow.providers.fab.auth_manager.api_fastapi.openapi import (
__file__ as fab_auth_manager_fastapi_api_file,
)
- from airflow.providers.fab.auth_manager.openapi import __file__ as
fab_auth_manager_flask_api_file
from airflow.providers.keycloak.auth_manager.openapi import (
__file__ as keycloak_auth_manager_fastapi_api_file,
)
- fab_auth_manager_flask_api_path =
Path(fab_auth_manager_flask_api_file).parent.joinpath(
- "v1-flask-api.yaml"
- )
fab_auth_manager_fastapi_api_path =
Path(fab_auth_manager_fastapi_api_file).parent.joinpath(
"v2-fab-auth-manager-generated.yaml"
)
keycloak_auth_manager_fastapi_api_path =
Path(keycloak_auth_manager_fastapi_api_file).parent.joinpath(
"v2-keycloak-auth-manager-generated.yaml"
)
redoc = [
- {
- "name": "Fab auth manager API",
- "page": "api-ref/fab-public-api-ref",
- "spec": fab_auth_manager_flask_api_path.as_posix(),
- "opts": {
- "hide-hostname": True,
- },
- },
{
"name": "Fab auth manager token API",
Review Comment:
It is no longer only the token API
```suggestion
"name": "Fab auth manager API",
```
##########
providers/fab/src/airflow/providers/fab/www/constants.py:
##########
@@ -18,11 +18,4 @@
from pathlib import Path
-from airflow.configuration import conf
-
WWW = Path(__file__).resolve().parent
Review Comment:
If I am not mistaken this is no longer used. If so, you can remove the
module entirely
##########
providers/fab/docs/auth-manager/api-authentication.rst:
##########
@@ -19,7 +19,7 @@ FAB auth manager API authentication
===================================
.. note::
- This guide only applies to :doc:`FAB auth manager API
</api-ref/fab-public-api-ref>`.
Review Comment:
Keep the link but link to `api-ref/fab-token-api-ref`, which should be
renamed `api-ref/fab-api-ref`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
