o-nikolas opened a new pull request, #62838:
URL: https://github.com/apache/airflow/pull/62838

   Previously, core executors like "LocalExecutor", "CeleryExecutor", etc could 
not be given aliases. This was because these executors already had a built in 
alias, they could be referenced with their shortnames alone, e.g.: 
`AIRFLOW__CORE__EXECUTOR="LocalExecutor"`). However, with multi-team, two 
instances of the same executor can be used across a team and globally, e.g.: 
`AIRFLOW__CORE__EXECUTOR="LocalExecutor;team_a=LocalExecutor "` In this case 
Dags from team_a should be able to use either the global or team based 
executors, however there is no unique way to reference them. Setting 
`executor=LocalExecutor` on a task, would always resolve to the team based 
executor.
   
   To fix this, we now allow core executors to receive aliases. This was a 
"soft" limit before, to reduce complexity, but it now solves this problem 
nicely. It is also backwards compatible since the previous "short name" for the 
core executors was always the same as the classname, which is now an acceptable 
input to the task's `executor` field.
   
   Update docs as well for both multi-team and multiple executor config.
   
    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull 
request.
   Write a good git commit message following this guide: 
http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the 
documentation.
   
   Feel free to ping (in general) for the review if you do not see reaction for 
a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we 
sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [ ] Yes (please specify the tool below)
   
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to