henry3260 commented on code in PR #62624:
URL: https://github.com/apache/airflow/pull/62624#discussion_r2884037074
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py:
##########
@@ -91,11 +92,13 @@
@ti_id_router.patch(
"/{task_instance_id}/run",
status_code=status.HTTP_200_OK,
- responses={
- status.HTTP_404_NOT_FOUND: {"description": "Task Instance not found"},
- status.HTTP_409_CONFLICT: {"description": "The TI is already in the
requested state"},
- HTTP_422_UNPROCESSABLE_CONTENT: {"description": "Invalid payload for
the state transition"},
- },
+ responses=create_openapi_http_exception_doc(
+ [
+ status.HTTP_404_NOT_FOUND,
+ status.HTTP_409_CONFLICT,
+ HTTP_422_UNPROCESSABLE_CONTENT,
Review Comment:
> After going through `create_openapi_http_exception_doc`, it looks the
changes you are introducing are removing context from these exceptions in
favour of standardization. The descriptions that you are removing are not
'noise' but important breadcrumbs for debugging. Is it possible for you to keep
them?
Thanks for the review! I don't have a strong preference on this, but since
my initial goal was standardization, I want to make sure this aligns with the
maintainers' thoughts. If the consensus is to keep the context, I'm more than
happy to revert it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
