YoannAbriel opened a new pull request, #62888:
URL: https://github.com/apache/airflow/pull/62888

   ## Problem
   
   `HiveServer2Hook.get_conn()` silently drops user-provided passwords when 
`auth_mechanism` is anything other than `LDAP`, `CUSTOM`, or `PLAIN`. When 
`auth_mechanism` defaults to `NONE` (the most common case), the password is 
never passed to `pyhive.hive.connect()`, which then defaults to sending `"x"` 
as the password on the wire. Users see their configured password ignored 
regardless of what they set in the connection form.
   
   ## Root Cause
   
   The password assignment in `get_conn()` was gated behind `if auth_mechanism 
in ("LDAP", "CUSTOM", "PLAIN")`. For any other auth mode, `password` stayed 
`None` even when `db.password` was explicitly set by the user.
   
   ## Fix
   
   Changed the condition to `if db.password:` so the user-provided password is 
always passed through to pyhive when set, regardless of the auth mechanism. 
Added a test verifying password pass-through with the default `NONE` auth 
mechanism.
   
   Closes: #62338
   
   <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code
   
   Generated-by: Claude Code following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to