YoannAbriel opened a new pull request, #62895:
URL: https://github.com/apache/airflow/pull/62895

   `OracleHook.get_conn()` ignores `conn.schema` when building the DSN. When 
users fill Host, Port, and Schema in the connection UI without setting 
`service_name` in extras, the DSN is constructed without any service name — 
causing `ORA-12504: TNS:listener was not given the SERVICE_NAME in 
CONNECT_DATA`.
   
   The Schema field in the UI maps to `conn.schema`, which for Oracle is 
typically the service name. This fix falls back to `conn.schema` as 
`service_name` when neither `service_name` nor `sid` is explicitly set in 
extras. Explicit extras still take precedence.
   
   Added three tests covering: schema-as-service-name fallback, service_name 
precedence over schema, and sid precedence over schema.
   
   Closes: #62526
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code
   
   Generated-by: Claude Code following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to