ferruzzi commented on code in PR #62688:
URL: https://github.com/apache/airflow/pull/62688#discussion_r2886401340
##########
task-sdk/src/airflow/sdk/definitions/deadline.py:
##########
@@ -126,13 +126,20 @@ class TYPES:
# Deadlines that should be created when the DagRun is queued.
DAGRUN_QUEUED: DeadlineReferenceTypes =
(ReferenceModels.DagRunQueuedAtDeadline,)
+ # Deadlines related to background Jobs (Scheduler, etc.)
+ JOB: DeadlineReferenceTypes = (ReferenceModels.JobStartDateDeadline,)
+
# All DagRun-related deadline types.
DAGRUN: DeadlineReferenceTypes = DAGRUN_CREATED + DAGRUN_QUEUED
+ # INCLUDE JOBS IN THE GLOBAL LIST
+ # ALL: DeadlineReferenceTypes = DAGRUN + JOB
Review Comment:
Mistake??
##########
airflow-core/src/airflow/models/deadline.py:
##########
@@ -478,6 +478,16 @@ def deserialize_reference(cls, reference_data: dict):
min_runs=min_runs,
)
+ class JobStartDateDeadline(BaseDeadlineReference):
+ """A deadline that returns a Job's start date."""
+
+ required_kwargs = {"id"}
Review Comment:
Let's use something more descriptive:
```suggestion
required_kwargs = {"job_id"}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
