cetingokhan commented on PR #62816: URL: https://github.com/apache/airflow/pull/62816#issuecomment-4000681149
Thanks for the guidance! I completely understand the "thin hook" approach and using a simpler method for Azure and LiteLLM. I just have one concern and wanted to get your thoughts on it. When I look at other providers, they seem to require entirely different parameters from the connection. For example: BedrockProvider uses aws_access_key_id, region_name, etc. GoogleVertexProvider uses service_account_file, project_id, etc. I'm a bit worried that if we only map api_key and base_url right now, we might eventually have to write endless if/elif blocks in the hook for every single provider's unique parameters in the future. But of course, if you wish, we can start as you suggested and then revise it as needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
