YoannAbriel opened a new pull request, #62918:
URL: https://github.com/apache/airflow/pull/62918

   ## Problem
   
   Deadline alerts fire even after a DAG run has failed. A user configured a 
180-minute deadline, the DAG failed within 10 minutes, but the deadline alert 
still triggered 3 hours later.
   
   ## Root Cause
   
   `DagRun.update_state()` only calls `Deadline.prune_deadlines()` in the 
success path. When a DAG run fails (task failure or deadlock), pending 
deadlines are never cleaned up, so the scheduler still fires them later.
   
   ## Fix
   
   Moved deadline pruning from the success-only block to the shared terminal 
state block that runs for both SUCCESS and FAILED states. Added a test for the 
failure case.
   
   Closes: #60927
   
   <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code
   
   Generated-by: Claude Code following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to