ruijiang-rjian commented on code in PR #62240: URL: https://github.com/apache/airflow/pull/62240#discussion_r2891122449
########## providers/amazon/tests/system/amazon/aws/example_sagemaker_unified_studio_notebook.py: ########## @@ -0,0 +1,134 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from datetime import datetime + +from airflow.providers.amazon.aws.operators.sagemaker_unified_studio_notebook import ( + SageMakerUnifiedStudioNotebookOperator, +) +from airflow.providers.amazon.aws.sensors.sagemaker_unified_studio_notebook import ( + SageMakerUnifiedStudioNotebookSensor, +) + +from tests_common.test_utils.version_compat import AIRFLOW_V_3_0_PLUS + +if AIRFLOW_V_3_0_PLUS: + from airflow.sdk import DAG, chain +else: + from airflow.models.baseoperator import chain # type: ignore[attr-defined,no-redef] + from airflow.models.dag import DAG # type: ignore[attr-defined,no-redef,assignment] + +from system.amazon.aws.utils import ENV_ID_KEY, SystemTestContextBuilder + +""" +Prerequisites: The account which runs this test must have the following: +1. A SageMaker Unified Studio Domain (with default VPC and roles) +2. A project within the SageMaker Unified Studio Domain +3. A notebook asset registered in the project with a known notebook_id + +This test calls the DataZone StartNotebookRun / GetNotebookRun APIs directly +via boto3 using standard IAM credentials. No MWAA environment emulation is performed. +""" + +DAG_ID = "example_sagemaker_unified_studio_notebook" + +# Externally fetched variables: +DOMAIN_ID_KEY = "DOMAIN_ID" +PROJECT_ID_KEY = "PROJECT_ID" +NOTEBOOK_ID_KEY = "NOTEBOOK_ID" + +sys_test_context_task = ( + SystemTestContextBuilder() + .add_variable(DOMAIN_ID_KEY) + .add_variable(PROJECT_ID_KEY) + .add_variable(NOTEBOOK_ID_KEY) + .build() Review Comment: a note for the system test: @Shnekit is working on updating the[ system test](https://github.com/apache/airflow/blob/main/providers/amazon/tests/system/amazon/aws/example_sagemaker_unified_studio.py) for SageMakerNotebookOperator, with the latest sdk 1.0.25, we shouldn't need to rely on env variables set in MWAA, we can modify this system test based on that later (not blocking for now) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
