potiuk commented on PR #62965: URL: https://github.com/apache/airflow/pull/62965#issuecomment-4008136140
> @potiuk @pierrejeambrun I am not sure if the i18n engine for variants needs a full translation? If pt-BR is only needing a subset of things translated as diff from pt to pt-BR - does the JSON lang files still need to contain _all_ or just the diff? > > If only DIFF, do we need to adjust breeze language checks for this? I honestly prefer duplication in this case rather than DRY. I think it's way better to have complete translation for variant because from translator point of view you will have hard time if you would like to change just one phrase to Portugues variant. This also splits responsibility and makes it difficult to decide - because when new phrase is added you woul have to make coordinated decision whether you at BR only or both slightly different and in order to do that, you would have to discuss it between multiple people. I think it's much cleaner from maintenance point of view to have two complete files - even if they will be largely the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
