anishgirianish commented on PR #62343:
URL: https://github.com/apache/airflow/pull/62343#issuecomment-4008414198
Hey @o-nikolas , @choo121600, thanks for the thorough review! I've addressed
all the feedback:
- Switched to _try_to_load_executor for routing and added a
supports_connection_test post-check.
- Connection tests now respect the parallelism budget and are counted in
executor slot accounting.
- Moved dispatch into the main scheduler loop.
- Fixed the team name / executor name mixup in the test.
- Added tests for slot budget exhaustion and unsupported executor cases.
- Snapshot is now cleared (SQL NULL) after terminal state.
Would like to request you for another look when you get a chance!
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
