shahar1 commented on code in PR #61659:
URL: https://github.com/apache/airflow/pull/61659#discussion_r2895397869
##########
providers/google/src/airflow/providers/google/cloud/transfers/salesforce_to_gcs.py:
##########
@@ -52,6 +53,10 @@ class SalesforceToGcsOperator(BaseOperator):
to the resulting data that marks when the data was fetched from
Salesforce. Default: False
:param gzip: Option to compress local file or file data for upload
:param gcp_conn_id: the name of the connection that has the parameters we
need to connect to GCS.
+ :param unwrap_single: If True, unwrap a single-element result list into a
plain string value
Review Comment:
Technically the current operator doesn't return anything - so there is no
real "backward-compatiblity" here (maybe compatiblity with similar operators).
I'd rather remove this flag and just return the `list[str]` to ensure
compatiblity with the future behavior of all similar operators (in any case
there's only one element in this list, so this flag doesn't really contribute
that much).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
