n-badtke-cg commented on code in PR #61855:
URL: https://github.com/apache/airflow/pull/61855#discussion_r2895579405
##########
chart/templates/workers/worker-deployment.yaml:
##########
@@ -367,6 +367,10 @@ spec:
- name: AIRFLOW__LOG_RETENTION_DAYS
value: "{{ .Values.workers.logGroomerSidecar.retentionDays }}"
{{- end }}
+ {{- if .Values.scheduler.logGroomerSidecar.retentionMinutes }}
+ - name: AIRFLOW__LOG_RETENTION_MINUTES
+ value: "{{ .Values.scheduler.logGroomerSidecar.retentionMinutes
}}"
+ {{- end }}
Review Comment:
It seems there was mishap :)
```suggestion
{{- if .Values.workers.logGroomerSidecar.retentionMinutes }}
- name: AIRFLOW__LOG_RETENTION_MINUTES
value: "{{ .Values.workers.logGroomerSidecar.retentionMinutes
}}"
{{- end }}
```
##########
chart/values.schema.json:
##########
@@ -13902,6 +13902,11 @@
"type": "integer",
"default": 15
},
+ "retentionMinutes": {
+ "description": "Total retention time is retentionDays +
retentionMinutes.",
+ "type": "integer",
+ "default": 0
+ },
Review Comment:
```suggestion
"retentionDays": {
"description": "Number of days to retain the logs when
running the Airflow log groomer sidecar. Total retention time is retentionDays
+ retentionMinutes.",
"type": "integer",
"default": 15
},
"retentionMinutes": {
"description": "Number of minutes to retain the logs
when running the Airflow log groomer sidecar. Total retention time is
retentionDays + retentionMinutes.",
"type": "integer",
"default": 0
},
```
Please check if the suggestion is working correctly
##########
Dockerfile:
##########
Review Comment:
As I already mentioned in https://github.com/apache/airflow/pull/61853, I
don't know if we need to change this here, see
https://github.com/apache/airflow/pull/61853#pullrequestreview-3796865378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
