shashbha14 commented on code in PR #62631:
URL: https://github.com/apache/airflow/pull/62631#discussion_r2899321027
##########
airflow-core/src/airflow/ui/src/pages/Dag/Dag.tsx:
##########
@@ -106,6 +93,32 @@ export const Dag = () => {
},
);
+ const isPartitionedAssetDag = dag?.timetable_summary === "Partitioned Asset";
+ const tabs = useMemo(
+ () => [
+ { icon: <LuChartColumn />, label: translate("tabs.overview"), value: ""
},
+ { icon: <FiBarChart />, label: translate("tabs.runs"), value: "runs" },
+ ...(isPartitionedAssetDag
+ ? [
+ {
+ icon: <FiLayers />,
+ label: translate("tabs.partitionedRuns"),
+ value: "partitioned_runs",
+ },
+ ]
+ : []),
+ { icon: <TaskIcon />, label: translate("tabs.tasks"), value: "tasks" },
+ { icon: <FiCalendar />, label: translate("tabs.calendar"), value:
"calendar" },
+ { icon: <FiUser />, label: translate("tabs.requiredActions"), value:
"required_actions" },
+ { icon: <RiArrowGoBackFill />, label: translate("tabs.backfills"),
value: "backfills" },
+ { icon: <MdOutlineEventNote />, label: translate("tabs.auditLog"),
value: "events" },
+ { icon: <FiCode />, label: translate("tabs.code"), value: "code" },
+ { icon: <MdDetails />, label: translate("tabs.details"), value:
"details" },
+ ...externalTabs,
+ ],
+ [translate, isPartitionedAssetDag, externalTabs]
+ );
Review Comment:
Addressed reviewer feedback:
- Removed the dedicated "Partitioned Runs" tab
- Instead, auto-apply run_type=asset_triggered filter on the existing Runs
tab when the DAG uses
PartitionedAssetTimetable
- Removed useMemo per react-compiler guidance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
