potiuk opened a new pull request, #63049:
URL: https://github.com/apache/airflow/pull/63049
…ance creation
Also Add regression test verifying the hook sees the correct run_id
In airflow/models/taskinstance.py, TI.__init__() calls
self.refresh_from_task(task) which invokes
task_instance_mutation_hook(task_instance) via _refresh_from_task().
However, self.run_id is not assigned until after this call, so any mutation
hook that depends on run_id sees None.
```python
self.refresh_from_task(task) # calls hook — self.run_id is None here
...
self.run_id = run_id # too late
```
This means a hook like the one in the issue:
```python
def task_instance_mutation_hook(task_instance):
if task_instance.run_id.startswith("manual__"):
task_instance.pool = "manual_pool"
```
fails with AttributeError: 'NoneType' object has no attribute 'startswith'
(or silently does nothing if guarded with getattr).
Move self.run_id = run_id before self.refresh_from_task(task) in
TI.__init__():
self.run_id = run_id # set BEFORE refresh_from_task
self.map_index = map_index
self.refresh_from_task(task) # hook now sees correct run_id
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
