jscheffl commented on code in PR #63042:
URL: https://github.com/apache/airflow/pull/63042#discussion_r2900344440
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -778,7 +778,7 @@ def check_kueue_deployment_running(
@staticmethod
def get_yaml_content_from_file(kueue_yaml_url) -> list[dict]:
"""Download content of YAML file and separate it into several
dictionaries."""
- response = requests.get(kueue_yaml_url, allow_redirects=True)
+ response = requests.get(kueue_yaml_url, allow_redirects=True,
timeout=30)
Review Comment:
I'd be okay to apply 30s timeout across K8s provider as usually all calls
should be short. But this here is a simple search&add. The K8s provider uses a
K8s API Client, is a timeout should be applied (and is not already) then it
needs to be passed down to API client (where a generic retry layer was added
recently)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
