sjyangkevin opened a new pull request, #63060:
URL: https://github.com/apache/airflow/pull/63060
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
related: #61984
### Why
Adds more clarity and make the instruction more like actionable steps. The
previous instruction looks more like a document reference, and only a small
section instructs the step-by-step workflow. However, the workflow can be
different between adding a new translation and maintaining an existing
translation. The updated instruction enhance the clarity, and provide
step-by-step guideline on how to proceed with each task.
Added an example showing exactly what the scaffolded files will look like
(e.g., "allRuns": "TODO: translate: All Runs"). This makes it more clear what
the agent is supposed to look for and edit.
Moved reference material, such as the General Translation Rules, Terms Kept
in English, and Plural Forms, below the workflow steps. Previously, an agent
had to read through all the theoretical rules before figuring out what actually
needed to be done. Now, the context is provided as reference material precisely
when it's needed. Also, these rules may be override in locale-specific
instruction; the phrasing also refined to make the instruction more clear when
should follow the locale-specific guideline.
Added a validation step, to instruct running the completion check and prek
command
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (please specify the tool below)
Generated-by: [Antigravity] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
