Miretpl commented on code in PR #63019:
URL: https://github.com/apache/airflow/pull/63019#discussion_r2900835547
##########
chart/docs/customizing-labels.rst:
##########
@@ -59,3 +59,66 @@ For example, to add specific labels to different components:
apiServer:
labels:
role: ui
+
+Customizing Pod Annotations
+============================
+
+Pod annotations can be customized similarly to labels using ``podAnnotations``
and ``airflowPodAnnotations``.
+
+Global Pod Annotations
+----------------------
+
+Global pod annotations can be set using ``airflowPodAnnotations``. These are
applied to all Airflow component pods (scheduler, API server, triggerer, dag
processor, workers, and webserver):
+
+.. code-block:: yaml
+ :caption: values.yaml
+
+ airflowPodAnnotations:
+ example.com/team: data-platform
+
+Component-Specific Pod Annotations
+-----------------------------------
Review Comment:
```suggestion
----------------------------------
```
##########
chart/docs/customizing-labels.rst:
##########
@@ -59,3 +59,66 @@ For example, to add specific labels to different components:
apiServer:
labels:
role: ui
+
+Customizing Pod Annotations
+============================
+
+Pod annotations can be customized similarly to labels using ``podAnnotations``
and ``airflowPodAnnotations``.
+
+Global Pod Annotations
+----------------------
+
+Global pod annotations can be set using ``airflowPodAnnotations``. These are
applied to all Airflow component pods (scheduler, API server, triggerer, dag
processor, workers, and webserver):
Review Comment:
```suggestion
Global pod annotations can be set using ``airflowPodAnnotations``. These are
applied to all Airflow component pods (scheduler, api-server/webserver,
triggerer, dag-processor and workers):
```
I think it would be more precise as you can deploy `api-server` or
`webserver`
##########
chart/docs/customizing-labels.rst:
##########
@@ -59,3 +59,66 @@ For example, to add specific labels to different components:
apiServer:
labels:
role: ui
+
+Customizing Pod Annotations
+============================
+
+Pod annotations can be customized similarly to labels using ``podAnnotations``
and ``airflowPodAnnotations``.
+
+Global Pod Annotations
+----------------------
+
+Global pod annotations can be set using ``airflowPodAnnotations``. These are
applied to all Airflow component pods (scheduler, API server, triggerer, dag
processor, workers, and webserver):
+
+.. code-block:: yaml
+ :caption: values.yaml
+
+ airflowPodAnnotations:
+ example.com/team: data-platform
+
+Component-Specific Pod Annotations
+-----------------------------------
+
+Each component also supports its own ``podAnnotations``. Component-specific
annotations take precedence over global ones:
+
+.. code-block:: yaml
+ :caption: values.yaml
+
+ scheduler:
+ podAnnotations:
+ example.com/component: scheduler
+
+Templated Pod Annotations
+--------------------------
Review Comment:
```suggestion
-------------------------
```
##########
chart/docs/customizing-labels.rst:
##########
@@ -59,3 +59,66 @@ For example, to add specific labels to different components:
apiServer:
labels:
role: ui
+
+Customizing Pod Annotations
+============================
Review Comment:
```suggestion
===========================
```
##########
chart/docs/customizing-labels.rst:
##########
@@ -15,8 +15,8 @@
specific language governing permissions and limitations
under the License.
-Customizing Labels for Pods
-===========================
+Customizing Labels and Annotations for Pods
+=============================================
Review Comment:
```suggestion
Customizing Labels for Pods
===========================
```
looking at the hierarchy this section is equal to new `Customizing Pod
Annotations`. We could also stay with this and add `Customizing Labels for
Pods` and `Customizing Pod Annotations` on `---` hierarchy level to be under
`Customizing Labels and Annotations for Pods`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
