SameerMesiah97 commented on code in PR #62990:
URL: https://github.com/apache/airflow/pull/62990#discussion_r2901120632
##########
providers/openfaas/src/airflow/providers/openfaas/hooks/openfaas.py:
##########
@@ -71,7 +71,8 @@ def deploy_function(self, overwrite_function_if_exist: bool,
body: dict[str, Any
else:
url = self.get_conn().host + self.DEPLOY_FUNCTION
self.log.info("Deploying function %s", url)
- response = requests.post(url, body)
+ timeout = int(self.get_conn().extra_dejson.get("timeout", 60))
+ response = requests.post(url, body, timeout=timeout)
Review Comment:
This does not belong in this PR. Can you create a new PR for introducing
timeouts to the OpenFaaS hook?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
