[ 
https://issues.apache.org/jira/browse/AIRFLOW-6254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16996256#comment-16996256
 ] 

ASF GitHub Bot commented on AIRFLOW-6254:
-----------------------------------------

potiuk commented on pull request #6817: [AIRFLOW-6254] obscure conn extra in 
logs
URL: https://github.com/apache/airflow/pull/6817
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> obscure conn extra in logs
> --------------------------
>
>                 Key: AIRFLOW-6254
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6254
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.10.6
>            Reporter: Daniel Standish
>            Assignee: Daniel Standish
>            Priority: Major
>             Fix For: 1.10.7
>
>
> When {{BaseHook.get_connection}} is called, it calls {{conn.log_info()}} on 
> the returned {{conn}} object.
> This is prints to log the full contents of {{conn.extra}}.
> This is problematic because there can be sensitive information in 
> {{conn.extra}}.
> The present change resolves this by adding method {{conn.log_info}} which 
> obscures {{extra}}, and calling that in {{get_connection}} instead of 
> {{debug_info}}.  
> The {{debug_info}} method itself is left unchanged.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to