[ 
https://issues.apache.org/jira/browse/AIRFLOW-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16996262#comment-16996262
 ] 

ASF GitHub Bot commented on AIRFLOW-6226:
-----------------------------------------

potiuk commented on pull request #6785: [AIRFLOW-6226] Always reset warnings in 
tests
URL: https://github.com/apache/airflow/pull/6785
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> warning.catch_warning should not be used in our code 
> -----------------------------------------------------
>
>                 Key: AIRFLOW-6226
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6226
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ci
>    Affects Versions: 2.0.0, 1.10.6
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> Sometime we use warning.catch_warnings in our code directly.
> As explained in [https://blog.ionelmc.ro/2013/06/26/testing-python-warnings/] 
> warnings are cached in "__warningregistry__" and if warning is emitted, it is 
> not emited for the second time.
>  
> Therefore warning.catch_warnings should never be used directly in our test 
> code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to