nuclearpinguin commented on a change in pull request #6820: [AIRFLOW-6255]
Redis Hook Refactor
URL: https://github.com/apache/airflow/pull/6820#discussion_r357936601
##########
File path: airflow/contrib/hooks/redis_hook.py
##########
@@ -66,3 +66,47 @@ def get_conn(self):
db=self.db)
return self.redis
+
+ def set_key_value(self, k, v):
Review comment:
```suggestion
def set_key_value(self, key: str, v: value: Any):
```
Using meaningful names is appreciated. Airflow also encourages adding type
annotations ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
