ShubhamGondane commented on PR #63084:
URL: https://github.com/apache/airflow/pull/63084#issuecomment-4020766028
After further review, found a few more improvements:
- Removed assetCount() and assetNames() from AssetListPage — dead code
after the refactor
- Replaced remaining snapshot-then-assert patterns (count() +
expect(count), assetNames() loop) with web-first assertions
- Removed the post-search name loop — redundant since expect.poll above
already verifies all results match
- Replaced expect(count).toBeGreaterThanOrEqual(minCount) in
AssetDetailPage with expect(button).toHaveText(/^[1-9]/) and dropped the
now-unused minCount parameter
@choo121600 Please review and let me know. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
