bugraoz93 commented on PR #63085: URL: https://github.com/apache/airflow/pull/63085#issuecomment-4021667580
> > Question. Should not that be a separate command to print the token (lile `gh auth login` `gh auth token` ?) . I am not sure if `gh auth login` should print things immediately after logging. And that would also allow to avoid the prompt/yes. - i.e. when you run `gh auth token` you absolutely expect the token to be printed, no extra warning and confirmation needed.. > > > > Or is there a good reason why to keep the output directly on login ? > > @potiuk, that's what I initially had in #62843 @bugraoz93 was concerned about the token being printed to stdout. I would prefer a separate command aswell. My intention here is to have a mechanism to get the token and manage the storage of the token asper our internal methodologies rather than having to go through keyring. My concern was more on directly printing the token without human interaction. My intention wasn't guide to the login in the previous PR. Sorry if I confused there! My idea was If we can add a flag to print or ask user on the token before flushing to console, that would reduce likelihood of people write `token` rather `login` in the command/automation from memory and token leaked with one word difference to monitoring/security tools -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
