vatsrahul1001 commented on code in PR #63185:
URL: https://github.com/apache/airflow/pull/63185#discussion_r2906064573
##########
airflow-core/src/airflow/migrations/versions/0082_3_1_0_make_bundle_name_not_nullable.py:
##########
@@ -43,63 +43,62 @@
def upgrade():
"""Make bundle_name not nullable."""
+ import contextlib
+
+ # We need the DagBundlesManager here to respect and validate the user
configured bundles instead of hardcoding 'dags-folder' and 'example_dags' as
the only two bundles.
+ from airflow.dag_processing.bundles.manager import DagBundlesManager
Review Comment:
No Migration script stays as is
> Do you mean move the batch update statement (UPDATE dag SET bundle_name =
:default_bundle WHERE bundle_name IS NULL) from migration script to
DagBundlesManager.sync_bundles_to_db?
So the two steps are:
1. Migration: set bundle_name = 'dags-folder' where NULL (satisfies NOT
NULL) remains unchanged
2. sync_bundles_to_db(): reassign DAGs with unconfigured bundle_name to the
actual configured bundle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
