jscheffl commented on code in PR #63176:
URL: https://github.com/apache/airflow/pull/63176#discussion_r2907862081
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -1004,6 +1004,13 @@ async def read_logs(
)
logs_list: list[str] = logs.splitlines()
return logs_list
+ except UnicodeDecodeError as e:
Review Comment:
Thanks for proposing a fix - we also saw this recently with Airflow 3.
Do you also see an alternative way to clean the bad characters and keep with
this at least some parts of the log message? Because otherwise if handled like
this it only will be visible in server logs and not user facing, which then is
hard to track down if a user calls and tells that "strange, some logs are
missing".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
