bbovenzi commented on PR #63081:
URL: https://github.com/apache/airflow/pull/63081#issuecomment-4026869717

   > > Is there a reason you chose to do an iframe plugin instead of a react 
one?
   > 
   > @bbovenzi no particular reason, but i here happy to take suggestions and 
apply them , please let me know.. if you feel react app is approach is better i 
will try to do that.. as noted above have no knowledge on UI part and infact 
this is the first time i am starting some UI work so I cant weigh between which 
one is better for the current work.. 😄
   
   Let's make it a react plugin since we are committing this into the main 
airflow repo and this is already a react component.
   
   It could be worth checking out our react-plugin-template which will already 
have UI components, async API request handling, and automatically detected dark 
mode. Would also make it easier to maintain in the long run if its more similar 
to the existing Airflow UI codebase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to