renu-j commented on code in PR #61951:
URL: https://github.com/apache/airflow/pull/61951#discussion_r2909346951
##########
providers/google/tests/unit/google/cloud/operators/test_dataproc.py:
##########
@@ -819,7 +819,7 @@ def test_execute(self, mock_hook, to_dict_mock):
# Test whether xcom push occurs before create cluster is called
self.extra_links_manager_mock.assert_has_calls(expected_calls,
any_order=False)
- to_dict_mock.assert_called_once_with(mock_hook().wait_for_operation())
+
to_dict_mock.assert_called_once_with(mock_hook.return_value.get_cluster.return_value)
if AIRFLOW_V_3_0_PLUS:
Review Comment:
Thanks for the clarification. I may have misunderstood the context here. I
was under the impression that the assertions were being applied to the same
mock instance, which would make the expectations inconsistent. If these are
indeed separate mocks or part of the legacy test branch, then the current
assertions make sense. Thanks for pointing that out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
