ashb commented on code in PR #62554:
URL: https://github.com/apache/airflow/pull/62554#discussion_r2910769768
##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -1414,9 +1414,21 @@ traces:
description: |
If True, then traces from Airflow internal methods are exported.
Defaults to False.
version_added: 3.1.0
+ version_deprecated: 3.2.0
+ deprecation_reason: |
+ This parameter is no longer used.
type: string
example: ~
default: "False"
+ otel_task_runner_span_flush_timeout_millis:
Review Comment:
millis vs msec no opinion on (Other than the "go duration" mode of
`1s`/`300ms` would be nice here but out of scope for this PR).
As for seconds vs milliseconds here: It appears the millis is only an
artifact of the Python API, and this isn't commonly set as an environment
variable in OTEL installs, so we can choose what makes most sense for us, so we
could have this as float number of seconds and convert to the format otel wants.
WDYT @uranusjr ?
##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -1414,9 +1414,21 @@ traces:
description: |
If True, then traces from Airflow internal methods are exported.
Defaults to False.
version_added: 3.1.0
+ version_deprecated: 3.2.0
+ deprecation_reason: |
+ This parameter is no longer used.
type: string
example: ~
default: "False"
+ otel_task_runner_span_flush_timeout_millis:
+ description: |
+ Timeout in milliseconds to wait for the OpenTelemetry span exporter to
flush pending spans
+ when a task runner process exits. If the exporter does not finish
within this time, any
+ buffered spans may be dropped.
+ version_added: 3.1.0
Review Comment:
```suggestion
version_added: 3.2.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
