potiuk opened a new pull request, #63263:
URL: https://github.com/apache/airflow/pull/63263
The deprecated option tests in `test_configuration.py` were registering fake
deprecated
option mappings at module level (`core.sql_alchemy_conn` →
`database.sql_alchemy_conn`)
that had been removed from the shared configuration project.
This mutation of the class-level `deprecated_options` dict caused
side-effects when tests
ran under xdist in different order, as the shared mutable state leaked
across test modules.
This PR replaces the removed `sql_alchemy_conn` deprecated mapping with the
real
`webserver.secret_key` → `api.secret_key` mapping that is already defined in
the shared
configuration's `deprecated_options`.
### Changes
- Removed fake `conf.deprecated_options[("database", "sql_alchemy_conn")]`
registration
- Updated all `test_conf_as_dict_when_deprecated_*` tests to use
`webserver/api secret_key`
- Updated test config files (`deprecated.cfg`, `deprecated_cmd.cfg`,
`deprecated_secret.cfg`)
- Renamed `test_deprecated_env_vars_upgraded_and_removed` →
`test_deprecated_env_vars_lookup`
- Removed stale `("core", "sql_alchemy_conn")` from `test_sensitive_values`
expected set
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Opus 4.6
Generated-by: Claude Opus 4.6 following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
