jedcunningham commented on PR #61448: URL: https://github.com/apache/airflow/pull/61448#issuecomment-4033293868
I'm still uncomfortable with the overlap this has with the existing `disable_bundle_versioning` flag/config. History wise: I think it is reasonable to want to track bundle_version history. But in practice it doesn't actually help since bundle_version is on dag_run and gets overwritten on clear anyway, right? I can see a use case for having both an option to force the latest behavior, while also allowing a default and letting the user have the final say. I just wonder if we can consolidate that into a single flag/config instead? These are so closely related... At the very least, we must explain in docs why they both exist and how they differ. It is not immediately obvious, especially to the end users who'd be making these choices. I also think we should use `DagModel.bundle_verison` (like we do already elsewhere) vs `DagBundleModel.version`. It could be many many minutes before the dag is reparsed, and that's a pretty long time to have a broken dagrun blowing `BundleVersionUnavailable`s imo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
