[
https://issues.apache.org/jira/browse/AIRFLOW-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16997400#comment-16997400
]
ASF GitHub Bot commented on AIRFLOW-6259:
-----------------------------------------
robinedwards commented on pull request #6828: [AIRFLOW-6259] Reset page with
each new search
URL: https://github.com/apache/airflow/pull/6828
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/AIRFLOW-6259
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Search incorrectly persists the page number which can confusingly
yield no results when making searches from 2nd page of dags onwards. This
very simple fix resets the page parameter to 0 on every new search.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Currently no framework for testing frontend changes like this.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
NA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Searching incorrectly persists the page number
> ----------------------------------------------
>
> Key: AIRFLOW-6259
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6259
> Project: Apache Airflow
> Issue Type: Bug
> Components: ui
> Affects Versions: 2.0.0, 1.10.6
> Reporter: Robin Edwards
> Assignee: Robin Edwards
> Priority: Minor
>
> When searching from outside of the first page of results the UI persists the
> `page=` GET param when making a new search. This can be very confusing and
> make user believe theres no results for the search.
> Steps to recreate:
> # start the webserver in demo / test mode.
> # manually set the page with a get parameter ?page=2 (no results will be
> displayed as expected)
> # search for "example" which will yield no results. You will notice in the
> get parameters ?page=2 has been persisted. Remove this and you will see the
> expected results
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
