Lee-W commented on issue #44146:
URL: https://github.com/apache/airflow/issues/44146#issuecomment-4037479077

   > 1. Should add_partition() allow arbitrary keys or only from a predefined 
set? The AIP example suggests arbitrary, but AllowedKeyMapper could optionally 
validate them. Worth adding?
   
   arbitrary keys seem to make more sense to me and defer to `AllowedKeyMapper` 
to do its job
   
   > PartitionMapper is consumer-side (to_downstream maps keys). 
PartitionAtRuntime is producer-side (creates keys). Should it be a separate 
abstraction, or still a PartitionMapper subclass? Given user-defined mappers 
aren't public for 3.2 (https://github.com/apache/airflow/issues/59294), should 
this be internal-only for now?
   
   I think it'll be part of 3.3. We're in a stage of keeping 3.2 as stable as 
possible. We've not yet looked too deeply into the runtime thing, but feel free 
to propose your idea. and we can see how we can get it better together :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to