github-advanced-security[bot] commented on code in PR #63365:
URL: https://github.com/apache/airflow/pull/63365#discussion_r2919926756
##########
airflow-core/src/airflow/api_fastapi/auth/managers/simple/simple_auth_manager.py:
##########
@@ -433,7 +433,13 @@
@staticmethod
def _print_output(output: str):
- name = "Simple auth manager"
- colorized_name = colored(f"{name:10}", "white")
- for line in output.splitlines():
- print(f"{colorized_name} | {line.strip()}")
+ from airflow.configuration import conf
+
+ if conf.getboolean("logging", "json_logs", fallback=False):
+ for line in output.splitlines():
+ log.info(line.strip())
Review Comment:
## Clear-text logging of sensitive information
This expression logs [sensitive data (password)](1) as clear text.
[Show more
details](https://github.com/apache/airflow/security/code-scanning/589)
##########
airflow-core/src/airflow/api_fastapi/auth/managers/simple/simple_auth_manager.py:
##########
@@ -433,7 +433,13 @@
@staticmethod
def _print_output(output: str):
- name = "Simple auth manager"
- colorized_name = colored(f"{name:10}", "white")
- for line in output.splitlines():
- print(f"{colorized_name} | {line.strip()}")
+ from airflow.configuration import conf
+
+ if conf.getboolean("logging", "json_logs", fallback=False):
+ for line in output.splitlines():
+ log.info(line.strip())
+ else:
+ name = "Simple auth manager"
+ colorized_name = colored(f"{name:10}", "white")
+ for line in output.splitlines():
+ print(f"{colorized_name} | {line.strip()}")
Review Comment:
## Clear-text logging of sensitive information
This expression logs [sensitive data (password)](1) as clear text.
[Show more
details](https://github.com/apache/airflow/security/code-scanning/590)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
