andreahlert commented on PR #61630: URL: https://github.com/apache/airflow/pull/61630#issuecomment-4041228555
> This fix looks reasonable in isolation, but several provider tests appear to have relied on the previous permissive behavior when `SUPERVISOR_COMMS `was absent or not initialized. By normalizing it to `None`, execution-time paths (particularly around connection resolution) are now enforced and fail loudly, which is causing widespread provider CI failures. It seems those tests did not anticipate `SUPERVISOR_COMMS ` being present but `None` and therefore entering these stricter code paths. It appears that provider tests might have to be loosened (or maybe connection resolution migh have to check for `SUPERVISOR_COMMS`) to accomodate this change but I am not going to make such a sweeping suggestion unilaterally. Thanks for the feedback. Already handled it with is_in_task_sdk_execution_context(), which checks that SUPERVISOR_COMMS is not None. Variable and Connection use it now, so provider tests keep the legacy path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
