potiuk commented on PR #61606: URL: https://github.com/apache/airflow/pull/61606#issuecomment-4041680186
@MrEhsanEllahi This PR has a few issues that need to be addressed before it can be reviewed — please see our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria). **Issues found:** - :x: **Description doesn't match code (AI-generated code signal)**: The PR description claims '22 test cases covering: Basic nested class imports (2-5 levels deep), Edge cases, Error handling' with '22/22 passed (100%)'. The actual diff adds exactly 1 new test assertion inside an existing test method. This is a textbook AI hallucination pattern — fabricating comprehensive test evidence that does not exist in the submitted code. - :x: **Gen-AI disclosure missing**: The Gen-AI disclosure checkbox is unchecked (`- [ ] Yes`). Multiple strong AI-generation signals are present: (1) fabricated test count (22 claimed vs 1 in diff), (2) highly formulaic numbered-algorithm description, (3) emoji-heavy before/after examples (✅ ❌), (4) overly precise specifics ('tested up to 5 levels') that cannot be verified from the diff. Per contributing guidelines, if generative AI tools were used to co-author the PR, the description must include a disclosure. - :warning: **Fragile internal string matching**: The condition `'is not a package' in error_msg` relies on the exact wording of Python's internal `ImportError` message, which is an undocumented implementation detail that may change across Python versions or interpreter implementations. This makes the backtracking logic brittle. - :warning: **Missing newsfragment**: This is a user-visible new feature (removing a documented limitation via a TODO comment), but no newsfragment file was added under `airflow-core/newsfragments/` or equivalent. Per project conventions, user-visible changes require a newsfragment. > **Note:** Your branch is **848 commits behind `main`**. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results. **What to do next:** - The comment informs you what you need to do. - Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed. - Maintainers will then proceed with a normal review. Please address the issues above and push again. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
