jscheffl commented on code in PR #63204:
URL: https://github.com/apache/airflow/pull/63204#discussion_r2920631921


##########
chart/templates/scheduler/scheduler-deployment.yaml:
##########
@@ -175,7 +175,7 @@ spec:
           envFrom: {{- include "custom_airflow_environment_from" . | default 
"\n  []" | indent 10 }}
           env:
             {{- include "custom_airflow_environment" . | indent 10 }}
-            {{- include "standard_airflow_environment" . | indent 10 }}
+            {{- include "standard_airflow_environment" (merge (dict 
"IncludeJwtSecret" true) .) | indent 10 }}

Review Comment:
   The "wait-for-migrations" does not need the JWT secret in my view.



##########
chart/templates/api-server/api-server-deployment.yaml:
##########
@@ -145,7 +145,7 @@ spec:
           envFrom: {{- include "custom_airflow_environment_from" . | default 
"\n  []" | indent 10 }}
           env:
             {{- include "custom_airflow_environment" . | indent 10 }}
-            {{- include "standard_airflow_environment" . | indent 10 }}
+            {{- include "standard_airflow_environment" (merge (dict 
"IncludeJwtSecret" true) .) | indent 10 }}

Review Comment:
   The "wait-for-migrations" does not need the JWT secret in my view.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to