jason810496 commented on code in PR #62696:
URL: https://github.com/apache/airflow/pull/62696#discussion_r2922723108
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -294,6 +299,9 @@ def __init__(
key="num_stuck_in_queued_retries",
fallback=2,
)
+ self._scheduler_use_job_schedule = conf.getboolean("scheduler",
"use_job_schedule", fallback=True)
+ self._parallelism = conf.getint("core", "parallelism")
+ self._multi_team = conf.getboolean("core", "multi_team")
Review Comment:
> These values are now frozen for the lifetime of the SchedulerJobRunner as
I see it?
Yes, but the lifetime of those values has been inconsistent for a while.
Some of them are effectively frozen when the SchedulerJobRunner is constructed
https://github.com/apache/airflow/blob/9d027a42683c82f23d3217925e442e4052ea1637/airflow-core/src/airflow/jobs/scheduler_job_runner.py#L285-L296
, while others behave as you described and are updated without a restart.
https://github.com/apache/airflow/blob/9d027a42683c82f23d3217925e442e4052ea1637/airflow-core/src/airflow/jobs/scheduler_job_runner.py#L1048
I’m not sure whether we should make all configuration usage fixed after
construction, or preserve the current behavior where configuration changes are
reflected without a restart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
