dondaum commented on code in PR #62984:
URL: https://github.com/apache/airflow/pull/62984#discussion_r2923407039
##########
providers/amazon/src/airflow/providers/amazon/aws/executors/batch/batch_executor.py:
##########
@@ -127,26 +128,40 @@ def __init__(self, *args, **kwargs):
def queue_workload(self, workload: workloads.All, session: Session | None)
-> None:
Review Comment:
Thanks for the review.
Are you refering to `ExecuteTask` and `ExecuteCallback` ?
https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/executors/workloads/__init__.py
I think we can only use it, if we pin the provider airflow-core depdency to
whenever this change was implemented. This happend here
https://github.com/apache/airflow/pull/61153.
If we want to keep backwards compatiability (currently the amazon provider
is pins `apache-airflow>=2.11.0"`
Thank you for the review.
Are you referring to types `ExecuteTask `and `ExecuteCallback`?
https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/executors/workloads/__init__.py
I think we can only use it if we pin the provider's Airflow core dependency
to when this change was implemented. This happened here
https://github.com/apache/airflow/pull/61153.
If we want to maintain backwards compatibility (currently the Amazon
provider is `apache-airflow>=2.11.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
