Desel72 opened a new pull request, #63447:
URL: https://github.com/apache/airflow/pull/63447
Replace Playwright anti-patterns with best practices in requiredAction spec
and RequiredActionsPage page object.
**Changes in RequiredActionsPage.ts:**
- Replace `locator('[data-testid="..."]')` with `getByTestId()` (3
occurrences)
- Replace `locator("table tbody tr")` with role-based `getByRole("row")`
- Remove `waitForTimeout(10_000)` arbitrary delay after HITL response
**Changes in requiredAction.spec.ts:**
- Replace `locator('th:has-text("...")')` with `getByRole("columnheader", {
exact: true, name: "..." })` (5 occurrences)
- Replace manual `isVisible()` boolean assertions with web-first `.or()`
locator pattern
closes: #63432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
