sidshas03 commented on PR #63355:
URL: https://github.com/apache/airflow/pull/63355#issuecomment-4047271802

   > @sidshas03 This PR has a few issues that need to be addressed before it 
can be reviewed — please see our [Pull Request quality 
criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria).
   > 
   > **Issues found:**
   > 
   > * ⚠️ **Unresolved review comments**: This PR has 1 unresolved review 
thread from maintainers. Please review and resolve all inline review comments 
before requesting another review. You can resolve a conversation by clicking 
'Resolve conversation' on each thread after addressing the feedback. See [pull 
request 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst).
   > 
   > > **Note:** Your branch is **155 commits behind `main`**. Some check 
failures may be caused by changes in the base branch rather than by your PR. 
Please rebase your branch and push again to get up-to-date CI results.
   > 
   > **What to do next:**
   > 
   > * The comment informs you what you need to do.
   > * Fix each issue, then mark the PR as "Ready for review" in the GitHub UI 
- but only after making sure that all the issues are fixed.
   > * Maintainers will then proceed with a normal review.
   > 
   > Please address the issues above and push again. If you have questions, 
feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack).
   
   Thanks for flagging this.
   
   I’m addressing the unresolved maintainer thread now (moving the 
duplicate-state handling to API side as suggested), then I’ll rebase this 
branch on latest `main` and push an updated commit.
   
   I’ll resolve the review conversation after the changes are in.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to