SameerMesiah97 commented on PR #61637: URL: https://github.com/apache/airflow/pull/61637#issuecomment-4049450387
> > @jscheffl > > I was hoping you could respond to my comment proposing a refinement to the approach i.e. turning this from an override parameter to an additional enumeration. If this is acceptable, I can proceed. > > Sorry, I was distracted the last weeks at work and kept my review work at minimum. Therefore also lagging "creative" moments for further ideas. I am a bit conservative on interfaces and changes, especially as KPO is so widely used. So my hope was some other maintainer has more feedback or opinions. > > If you force me to an opinion: I do not have a problem with the current selection and even if in theory there are 31 options I think in my use cases I thought of I am not missing any. But you can convince me of a use case not covered. Else I know how hard it is for people to use Airflow and I am fearing more of problems of mental load and complexity with less benefit. Except if there is a use case... Okay. So, in other words, you feel that it is worthwhile even as an additional enum? Is that correct? If that is the case, what should become of this PR? Should we leave it open for other maintainers to weigh in? Or just close it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
