passionworkeer commented on issue #55866: URL: https://github.com/apache/airflow/issues/55866#issuecomment-4049751306
A minimal fix path would be to stop overloading execution_timeout for two different semantics. I’d add a dedicated esponse_timeout: timedelta | None for the HITL wait window, compute the trigger deadline from that field only, and keep execution_timeout as the outer task guard. For compatibility, if esponse_timeout is None and execution_timeout is not None, you can temporarily map esponse_timeout = execution_timeout with a deprecation warning. It would also help to validate execution_timeout > notifier_budget + response_timeout when both are set, so slow notifiers do not consume the entire human-response window before defer() happens. A focused regression test is: use a notifier that sleeps ~2s, set execution_timeout=1s, esponse_timeout=10s, and assert the task still defers instead of timing out in the pre-defer path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
